chore: Use proper types for configure methods (Extension/Mark/Node)
#5421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nperez0111
approved these changes
Jul 31, 2024
bdbch
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Our Typist package (based on Tiptap) is still using
v2.3.0for now, and while attempting a quick upgrade to the latest version, some type checks started to fail (ref).One of the issues is that calling
Extension.create().configure()returnsNode<any, any>, whereas before it would returnNode<Options, Storage>. This PR fixes that by making sure that when.configure()is called for anExtension,Node, orMark, the correct type is returned.Would love it if this could be reviewed, merged, and release soon, so that we can upgrade our Tiptap version.
Testing Done
Built Tiptap locally and checked the generated
.d.tsfiles, the expected types were there.Verification Steps
Same as above. Build Tiptap, and check that the
.d.tsfiles are generated with the currect types for the.configure()method.Checklist